fix: bound reconciliation#1629
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Bound cache reconciliation so it can’t stall on a growing event stream, and reduced noisy retries by backing off only on real failures and pruning expired backoffs.
pkg/repository/events_s2.go: Capped total S2 records read when coalescing required content; paginate until the cap and warn if hit to ensure reconciliation completes.pkg/worker/cache_reconciler.go: Classified outcomes so only real failures are backed off; pruned expired backoffs each cycle and cleared on success to bound memory; refined logs (debug for attempts/misses, info on success, warn on failure) with durations.Written for commit 2bc05e3. Summary will update on new commits.