Skip to content

cleanup discovery logs#1639

Merged
luke-lombardi merged 1 commit into
mainfrom
ll/cleanup-discovery-logs
Jun 4, 2026
Merged

cleanup discovery logs#1639
luke-lombardi merged 1 commit into
mainfrom
ll/cleanup-discovery-logs

Conversation

@luke-lombardi
Copy link
Copy Markdown
Contributor

@luke-lombardi luke-lombardi commented Jun 4, 2026

Summary by cubic

Tightened cache discovery warnings to count only unresolved hosts and candidates, reducing noisy and misleading logs. Resolved groups are skipped before counting and verification.

  • Bug Fixes
    • Count unresolvedHosts, unresolvedCandidates, and unresolvedEndpointCandidates only for groups without an endpoint in pkg/cache/discovery.go.
    • Early-continue when a group already has an endpoint; exclude from warning totals.
    • Updated warning text to say "unresolved" and report accurate host/candidate counts with the last error.

Written for commit 938c0a3. Summary will update on new commits.

Review in cubic

@luke-lombardi luke-lombardi merged commit 74d3188 into main Jun 4, 2026
3 of 4 checks passed
@luke-lombardi luke-lombardi deleted the ll/cleanup-discovery-logs branch June 4, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants