fix: fixes parsing of sort fields#431
Merged
Merged
Conversation
grzuy
force-pushed
the
fix-sort-underscore
branch
from
2c7f649 to
4a21656
Compare
grzuy
changed the title
Member
|
This is a breaking change in some ways, but it does align handling with the more common case (includes and fieldsets are already done this way) and since the next step is atomizing it is probably safe to assume that in nearly every case the desire is not to use strange camel-case atoms. Let's go for it and see if it causes problems for folks since that seems really unlikely. |
mattpolzin
approved these changes
May 22, 2026
Contributor
Author
|
Thank you very much 🙏 |
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
An attempt to partially fix sort issues mentioned in #285 when sort fields are dasherized or camelCased.
Hope is useful to others.