Allow patterns to have all possible lengths #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, a HUGE thank you for this great project! I really appreciate it. We are a Batucada in Zurich and are now using this great application for all our rhythms (unfortunately I'm not allowed to publish them).
Since we have some patterns with lengths that can't be devided into 4 steps, I had to find a way to display them in this player. This is the (hacky) way I came up with. Would it be possible to add the ability to have different lengths of patterns like this?
Unfortunately, this only works for the pattern player and example songs, not for the composer. It's not a big deal for us, but if I could get some help on how to implement this and also how to make my solution nicer, I'd be happy to spend more time on it.