Conversation
* Update Makefile moving `go tool cover -func=c.out` to the `make test` statement * Update README.md adding badge for build/test with github workflows * Add refactor Parse() breaking out logic into getNumAndUnitRunes() and getMultiplierForUnitString() to reduce high gocyclo complexity * Added support for processing negative numbers to getNumAndUnitRUnes() so that we can throw proper errors when we get bad negative values. * Change Type() to return `bytesize.Bytes` instead of `bytes` * Update String() to return default value Lo uint64 as B Bytes. Though it should be impossible to hit this, but we have it just incase. * Fix unit test for TestParseErrors() * Add TestSet() and TestSetError() for testing Set() * Add TestGet() for testing Get() * Add TestType() for testing Type() * Add TestUnmarshalText() for testing UnmarshalTexT() * Add methods to Uint128: AddErr(), Add64Err(), SubErr(), Sub64Err(), MulErr(). And Updated Mul64Error() to Mul64Err(). * Add method to Uint128 FromBigErr() * Update unit test for Uint128 to support new Err Methods: TestUint128() * Add unit test for Uint128 to support new Err Methods: TestArithmeticErrors(), TestOverflowAndUnderflowErrors(), TestTrailingZeros(), TestOnesCount(), TestRotateLeft(), TestRotateRight(), TestReverse(), TestReverseBytes(), TestLen()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go tool cover -func=c.outto themake teststatementbytesize.Bytesinstead ofbytes