fix(redis_connector): filter_topics_cb != instead of is not#896
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hotfix to use != instead of is not when comparing callbacks during topic unsubscription, so that bound methods (which produce a new method object on each attribute access but compare equal via __eq__) are correctly identified and removed.
Changes:
- Replace identity comparison with equality comparison in
_filter_topics_cbso bound methods can be unsubscribed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d-perl
approved these changes
May 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hotfix for unsubscribing with
!=check. Previous indentity check would never unsubscribe bound methods (so basically anything from BEC Widgets) leading to pile up redis.