Conversation
…mline deployments, otherwise fallback to default cfg
cappel89
force-pushed
the
feat/update_pre_startup_get_config
branch
from
7cb3be0 to
b064f63
Compare
Contributor
Author
|
tested with csaxs repo and deployment, works |
Member
|
@ivan-usov what do you think? |
Contributor
|
oops, sorry for the merge commit, forgot to change the dropdown to rebase since it's now default on our other repos |
Contributor
|
this looks good to me and works well, but does it belong in the plugin repo? if we want to give users the ability to override the config in the yaml file then this code could be hidden from them instead, no? |
|
Looks good to me. Then this relative to the deployment folder location can be a place for a bec client's config. |
ivan-usov
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the get_config handling within plugin repositories to automatically identify if bec is launche within a deployment, and thereby identify the bec_config.yaml file. If the file is not found, we will use the default config with localhost:6379 instead. This change will work for all beamlines and plugin repositories directly.