Validating UEI Specification and examples against the Beckn Core specification v 1.1.0#18
Merged
ravi-prakash-v merged 11 commits intobeckn:mainfrom Sep 25, 2024
Merged
Conversation
|
Hey @rajaneeshk90 , Please find my comments on the pull request below :
I was hoping you could find the complete difference in the given comparison link (click here). Please make the required change and update the pull request. Thanks |
6 tasks
Contributor
Author
|
Hi @emmayank I have fixed the highlighted issues. Can you please review this PR. There are more changes made to fix any non compliance in the UEI spec with the Beckn core specifications version 1.1.0. Please let me know if any clarification is needed. Thanks, |
6 tasks
Adding a "Try it out" button in the ReadMe
ravi-prakash-v
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
There are some components of the UEI specification which are not as per the Beckn core specification version 1.1.0
One such issue is highlighted below.
As per the UEI specification, "city" field should be enclosed inside context.location object.
Definition of the context in UEI specification can be found here: https://github.com/beckn/Unified-Energy-Interface/blob/main/api/dent.yaml#L2735
All the JSON examples in the UEI repository directly utilize the "city" field within the context.
More details of the issue can be found on the GitHub issue page of UEI repository: #17
As part of this task, we checked the UEI spec and example JSONs for any non-compliance with Beckn core spec version 1.1.0 and fixed the identified issues.
Change Made
Related ticket: beckn/beckn-ui-workspace#485