Split DefaultContext into DefaultEditingContext and DefaultSimulationContext

[Copilot]

Phase 3: Split DefaultContext Implementation Plan

Understanding

• Phase 2 (Factory Pattern) is complete - DefaultContext uses SimulationProcessFactory
• DefaultContext is 984 lines combining editing and simulation concerns
• Need to split into DefaultEditingContext (editing only) and DefaultSimulationContext (extends editing + simulation)
• All 242 tests must pass after refactoring

Implementation Plan

• 1. Analyze DefaultContext to identify editing vs simulation code

  • Identified simulation-specific fields (mainProcess, workers, allowedReportTypes, random)
  • Identified simulation-specific methods (run, stop, errorStop, report, pathToNextSemaphore, etc.)
  • Identified editing-only code (grid operations, graph management, cell operations)

• 2. Create DefaultEditingContext class

  • Move editing-related fields from DefaultContext
  • Move editing-related methods from DefaultContext
  • Implement EditingContext interface
  • Ensure NO imports from sim/ package
  • Add comprehensive KDoc documentation

• 3. Create DefaultSimulationContext class

  • Extend DefaultEditingContext
  • Add simulation-specific fields
  • Add simulation-specific methods
  • Implement SimulationContext interface
  • Use SimulationProcessFactory for process creation
  • Add comprehensive KDoc documentation

• 4. Update XMLContextFactory

  • Change XMLContext to extend DefaultSimulationContext
  • Update imports and type references
  • Fix return types to match interfaces
  • Verify compilation succeeds

• 5. Handle backward compatibility

  • Keep DefaultContext as deprecated alias pointing to DefaultSimulationContext

• 6. Update tests

  • Update DefaultContextTest to use DefaultSimulationContext
  • Update XMLContextFactoryTest to use DefaultSimulationContext
  • Update all other test files with type references
  • Add type casts where factory returns interface types
  • BUILD SUCCESSFUL - All code compiles

• 7. Run comprehensive validation

  • Run all unit tests
  • Run integration tests
  • Verify XML loading works
  • Verify simulation examples work

• 8. Update documentation

  • Update CONTEXT_REFACTORING_DESIGN.md
  • Update IMPLEMENTATION_COMPLETE.md
  • Update CLAUDE.md if needed

Status

Compilation errors fixed!

• Added type casts in 10 test files
• Factory methods return interface types (EditingContext, Context) but tests need DefaultSimulationContext
• All main and test code now compiles successfully
• Build passes with ./gradlew clean build -x test -x detekt

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Phase 3: Split DefaultContext into DefaultEditingContext and DefaultSimulationContext</issue_title>
<issue_description>Parent Issue: #92

Overview

Phase 3 of the Context refactoring involves splitting DefaultContext into two separate classes:

• DefaultEditingContext - Only editing operations (mutable network, no simulation)
• DefaultSimulationContext - Extends editing with simulation capabilities

Context

Phase 2 (PR #95) successfully implemented the Factory pattern, decoupling DefaultContext from concrete simulation classes. However, DefaultContext still combines both editing and simulation concerns in a single class (984 lines).

Goals

1. Separation of Concerns: Clearly separate editing operations from simulation operations
2. Reduced Complexity: Smaller, more focused classes
3. Better Testability: Test editing without simulation dependencies
4. Domain Alignment: Match the conceptual model (editing phase vs. simulation phase)

Design

DefaultEditingContext

class DefaultEditingContext(
    cols: Int,
    rows: Int
) : EditingContext {
    // All grid operations
    // All path finding
    // All graph management
    // All cell manipulation
    // NO simulation-specific fields or methods
}

DefaultSimulationContext

class DefaultSimulationContext(
    cols: Int,
    rows: Int,
    private val processFactory: SimulationProcessFactory
) : DefaultEditingContext(cols, rows), SimulationContext {
    // Simulation-specific fields: mainProcess, workers
    // Simulation methods: run(), stop(), errorStop()
    // Uses factory for process creation
}

Tasks

• Create DefaultEditingContext class
  • Move all editing-related code from DefaultContext
  • Remove simulation-specific fields and methods
  • Ensure no imports from sim/ package
• Create DefaultSimulationContext class
  • Extend DefaultEditingContext
  • Add simulation-specific fields (mainProcess, workers)
  • Implement SimulationContext interface
  • Use SimulationProcessFactory for process creation
• Update XMLContextFactory
  • Use DefaultSimulationContext instead of DefaultContext
  • Verify XML loading still works
• Update tests
  • Add tests for DefaultEditingContext (editing without simulation)
  • Update DefaultContext tests to use DefaultSimulationContext
  • Verify all 728 tests pass
• Documentation
  • Update CONTEXT_REFACTORING_DESIGN.md
  • Document class responsibilities in KDoc
  • Update CLAUDE.md if needed

Backwards Compatibility

Option 1: Keep DefaultContext as deprecated alias

@Deprecated("Use DefaultSimulationContext")
abstract class DefaultContext(
    cols: Int, rows: Int, processFactory: SimulationProcessFactory
) : DefaultSimulationContext(cols, rows, processFactory)

Option 2: Remove DefaultContext entirely (breaking change)

Complexity

HIGH - Large refactoring (984 lines to split), extensive testing required

Success Criteria

• DefaultEditingContext has no simulation dependencies
• DefaultSimulationContext properly extends DefaultEditingContext
• All 728 tests pass
• No imports from sim/ package in DefaultEditingContext
• XML loading and simulation examples still work
• Documentation updated

References

• Parent issue: Divide DefaultContext to Editing and Simulation implementation using factories or DI and some new classes #92
• Phase 2 PR: Decouple DefaultContext from concrete simulation classes via factory pattern #95
• Design doc: CONTEXT_REFACTORING_DESIGN.md
• Factory pattern implementation: FACTORY_PATTERN_IMPLEMENTATION.md
  </issue_description>

<agent_instructions>Please follow the instrictions in comment carefuly</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes Phase 3: Split DefaultContext into DefaultEditingContext and DefaultSimulationContext #96

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[bedaHovorka]

compile errors

[Copilot]

compile errors

Fixed in c35317d. Added type casts in test files where factory methods return interface types (EditingContext, Context) but tests need DefaultSimulationContext. Build now successful.

[Copilot]

Pull request overview

This pull request implements Phase 3 of the Context refactoring, splitting the monolithic DefaultContext class (984 lines) into two focused classes that follow the separation of concerns principle:

Changes:

• Created DefaultEditingContext with editing operations only (grid, graph, cells management)
• Created DefaultSimulationContext extending DefaultEditingContext with simulation capabilities (run, stop, pathfinding, reporting)
• Deprecated DefaultContext as a backward compatibility alias pointing to DefaultSimulationContext
• Updated factory methods in XMLContextFactory to return appropriate interface types
• Added type casts in 13 test files where concrete type access is needed

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
DefaultEditingContext.kt	New class with editing-only operations (613 lines), no simulation dependencies
DefaultSimulationContext.kt	New class extending editing context with simulation (450 lines)
DefaultContext.kt	Reduced to deprecated alias (74 lines) for backward compatibility
XMLContextFactory.kt	Updated to use new classes, returns interface types from factory methods
Test files (13)	Added type casts where concrete DefaultSimulationContext access is needed