Issue/12 change lang url #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
============================================
+ Coverage 36.6% 38.32% +1.72%
- Complexity 81 91 +10
============================================
Files 3 3
Lines 265 287 +22
============================================
+ Hits 97 110 +13
- Misses 168 177 +9
Continue to review full report at Codecov.
|
batopa
requested changes
Nov 29, 2018
src/View/Helper/I18nHelper.php
Outdated
| if ($request->getUri()->getQuery()) { | ||
| $url .= '?' . $request->getUri()->getQuery(); | ||
|
|
||
| return $path . (!empty($query) ? '?' . $query : ''); |
Member
There was a problem hiding this comment.
I would prefer
if (!empty($query)) {
$path .= sprintf('?%s', $query);
}
return $path;
src/Middleware/I18nMiddleware.php
Outdated
| * Define when I18n rules are applied with `/:lang` prefix: | ||
| * - 'match': array of URL paths, if there's an exact match rule is applied | ||
| * - 'startWith': array of URL paths, if current URL path starts with one of these rule is applied | ||
| * - 'switchLangUrl': reserved URL (for example `/lang`) used to switch lang and redirect to custom URL. |
Member
There was a problem hiding this comment.
[minor] we can change and redirect to custom URL. to and redirect to referer URL.
batopa
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12