Skip to content

fix: avoid double redirect if / is in match config #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stefanorosanelli merged 3 commits into from
Dec 20, 2019
Merged

fix: avoid double redirect if / is in match config #25

stefanorosanelli merged 3 commits into from
Dec 20, 2019

Conversation

@batopa
Copy link
Member

@batopa batopa commented Dec 20, 2019

The issue happens when I18nMiddleware is configured with 'match' => '/'

At the moment https://example.com redirects first to https://example.com/en/ then to https://example.com/en.

After the fix it will be redirect directly to https://example.com/en

Bonus track: update codesniffer 😱

@batopa batopa added the bug Something isn't working label Dec 20, 2019
@stefanorosanelli stefanorosanelli merged commit b8f7d2f into master Dec 20, 2019
@stefanorosanelli stefanorosanelli deleted the fix/avoid-double-redirect-on-root branch December 20, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanorosanelli stefanorosanelli stefanorosanelli approved these changes

Assignees

@stefanorosanelli stefanorosanelli

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@batopa @stefanorosanelli