Send correct data to queue#215
Closed
pturley wants to merge 1 commit into
Closed
Conversation
skeggse
requested changes
Aug 5, 2020
Member
skeggse
left a comment
skeggse
left a comment
There was a problem hiding this comment.
Could you expand on what this accomplishes? On how I can verify this fixes that problem? It seems odd to me that we'd be passing an array as the second parameter to Queue#add.
Author
|
@skeggse The basic issue was that when I would click the retry job button the data for the job wasn't passed correctly into the new job that was created. Enough time has passed, so I dont have the example any more, but the issue was that I could not successfully retry jobs with data in the same format. |
Member
|
Got it. If you run into this again, feel free to re-open! |
Member
|
I also suspect this might have been fixed by #223. |
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup:
When retrying a completed job using the job data was being sent under the data key. This actually triggers the job with the correct data.