Add jsoneditor code and text mode options#217
Merged
Conversation
Contributor
Author
|
|
roark
force-pushed
the
jsoneditor-modes
branch
2 times, most recently
from
1767cc9 to
3e248fa
Compare
|
This is the most awaited feature :D @LewisJEllis, @skeggse can we get this merged? |
skeggse
force-pushed
the
jsoneditor-modes
branch
2 times, most recently
from
3e248fa to
2d68a56
Compare
skeggse
force-pushed
the
jsoneditor-modes
branch
from
2d68a56 to
5f7d2a5
Compare
skeggse
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #208 and #53
Adds
codeandtextmodes to the jsoneditor. (as well as originaltreemode)I also expanded the jsonEditor height to 300px. More vertical space was required for
treemode popover prompts andcode/texteditor parse warn messages.Please let me know if there is anything else I can do to get this Pull Request merged in. Thanks for the useful tool.