Fix capitalize function#339
Merged
Merged
Conversation
roggervalf
commented
Mar 8, 2021
| @@ -1,16 +1,18 @@ | |||
| {{#unless displayJobInline}} | |||
| <h3>{{ this.id }}</h3> | |||
| <h3>{{ this.id }}</h3> | |||
Collaborator
Author
There was a problem hiding this comment.
most of the changes are linting changes
|
|
||
| capitalize(s) { | ||
| capitalize(value) { | ||
| if (typeof value !== 'string') { |
Collaborator
Author
There was a problem hiding this comment.
the problem is that here, s is not evaluated, so it returns '' string always
roggervalf
force-pushed
the
fix-capitalize-function
branch
from
314f0ec to
48ca96a
Compare
Collaborator
Author
|
Please @bradvogel when you get a chance, some 👀 on this fix |
roggervalf
commented
Mar 8, 2021
| {{/if}} | ||
| </div> | ||
|
|
||
| {{#if this.processedOn}} |
Collaborator
Author
There was a problem hiding this comment.
these lines were added
roggervalf
commented
Mar 8, 2021
| @@ -1,5 +1,7 @@ | |||
| # Arena | |||
|
|
|||
| [](https://www.npmjs.com/package/bull-arena) [](https://github.com/prettier/prettier) [](https://www.npmjs.com/package/bull-arena) [](https://github.com/semantic-release/semantic-release) | |||
Collaborator
Author
There was a problem hiding this comment.
Maybe it could be nice to have some badgets
bradvogel
approved these changes
Mar 8, 2021
|
|
||
| capitalize(s) { | ||
| capitalize(value) { | ||
| if (typeof value !== 'string') { |
Collaborator
|
🎉 This PR is included in version 3.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the capitalize function since is not using the real value that is passed. Also I'm adding processed on and finished on values in jobDetails