Skip to content

Adding executes at detail#340

Merged
bradvogel merged 5 commits into
bee-queue:masterfrom
roggervalf:feat-executes-at
Mar 10, 2021
Merged

Adding executes at detail#340
bradvogel merged 5 commits into
bee-queue:masterfrom
roggervalf:feat-executes-at

Conversation

@roggervalf
Copy link
Copy Markdown
Collaborator

@roggervalf roggervalf commented Mar 10, 2021

This PR tries to show an Executes at detail for jobs that have delay, so in case delay is missing this details is not going to be showed. #145

@bradvogel
Copy link
Copy Markdown

bradvogel commented Mar 10, 2021

Is this ready for review? If so, please request me for review so I get notified:
image

@roggervalf
Copy link
Copy Markdown
Collaborator Author

Is this ready for review? If so, please request me for review so I get notified:
image

Please @bradvogel review it when have a chance, it does not appear that option :(, sorry for the delay
Selection_011

@bradvogel bradvogel self-requested a review March 10, 2021 20:57
@bradvogel
Copy link
Copy Markdown

oh! strange that option isn't available. If I don't respond to a future PR, just @-tag me in a comment so I can review.

</div>
{{/if}}

{{#if this.delay}}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for Bull only? I don't see it for Bee. My repro steps:

  1. Add code await queue.createJob({}).delayUntil(Date.now() + 60 * 1000).save(); here.
  2. Run npm run start:bee from the examples dir

Separately, how can I add a similar line of code to the Bull example to test this feature?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I added delayed examples. For Bee:
Selection_012
it is not currently supported to show delay, so as delay does not exist as a value, it does not appear. In Bull:
Selection_013
appears

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, I guess I found how to make it works in Bee, let me try something

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now it supports Bee queue too
Selection_014

@bradvogel bradvogel merged commit bef9feb into bee-queue:master Mar 10, 2021
@beequeueci
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants