Adding executes at detail#340
Merged
Merged
Conversation
Collaborator
Author
Please @bradvogel review it when have a chance, it does not appear that option :(, sorry for the delay |
|
oh! strange that option isn't available. If I don't respond to a future PR, just @-tag me in a comment so I can review. |
bradvogel
suggested changes
Mar 10, 2021
| </div> | ||
| {{/if}} | ||
|
|
||
| {{#if this.delay}} |
There was a problem hiding this comment.
Is this for Bull only? I don't see it for Bee. My repro steps:
- Add code
await queue.createJob({}).delayUntil(Date.now() + 60 * 1000).save();here. - Run
npm run start:beefrom the examples dir
Separately, how can I add a similar line of code to the Bull example to test this feature?
Collaborator
Author
Collaborator
Author
There was a problem hiding this comment.
wait, I guess I found how to make it works in Bee, let me try something
Collaborator
Author
bradvogel
approved these changes
Mar 10, 2021
Collaborator
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





This PR tries to show an Executes at detail for jobs that have delay, so in case delay is missing this details is not going to be showed. #145