fix(queue): always close eclient conn if it exists#178
Merged
skeggse merged 1 commit intobee-queue:masterfrom Jan 27, 2020
Merged
fix(queue): always close eclient conn if it exists#178skeggse merged 1 commit intobee-queue:masterfrom
skeggse merged 1 commit intobee-queue:masterfrom
Conversation
Before, the eclient was created if this was true (see line 77):
```
this.settings.getEvents || this.settings.activateDelayedJobs
```
But then it was closed iff `this.settings.getEvents` was true, which
meant that `close()` would fail to terminate all connections if the
settings were `{ getEvents: false, activateDelayedJobs: true }`.
Contributor
Author
|
@skeggse FYI, the travis failure seems unrelated to this change; looks like eslint ships some modern JS code that's not compatible with older versions of Node |
Member
|
@ethanresnick good catch, thanks! |
skeggse
approved these changes
Jan 27, 2020
Contributor
Author
|
Sure thing. Thanks for merging so quickly :) Any chance a new version can be published to npm with this fix? I need it for my current project, and would rather not have to create a distinct npm package to depend on |
Member
|
Released in |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the eclient was created if this was true (see line 77):
But then it was closed iff
this.settings.getEventswas true, whichmeant that
close()would fail to terminate all connections if thesettings were
{ getEvents: false, activateDelayedJobs: true }.