Skip to content

Fix forked SQLite connection handling to improve test accuracy (#3249)#3386

Merged
zinduolis merged 24 commits into
masterfrom
red/dev
Sep 7, 2025
Merged

Fix forked SQLite connection handling to improve test accuracy (#3249)#3386
zinduolis merged 24 commits into
masterfrom
red/dev

Conversation

@zinduolis
Copy link
Copy Markdown
Contributor

@zinduolis zinduolis commented Aug 25, 2025

Pull Request

Thanks for submitting a PR! Please fill in this template where appropriate:

Category

Tests

Feature/Issue Description

Q: Please give a brief summary of your feature/fix
A: Improve SQLite connection handling to fix test flakiness.

Q: Give a technical rundown of what you have changed (if applicable)
A: Add disconnect_all_active_record! calls before forking in multiple specs for improved SQL connection handling safety. Also fixed API Error.

Test Cases

Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: This fix is purely for tests to be more stable and from tests running by GitHub actions, from the checks running on this PR it will be evident when errors and warnings disappear.

Wiki Page

If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.

…; refactor spec_helper.rb for improved fork handling
…ecs for improved SQL connection handling safety
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 25, 2025 13:34 — with GitHub Actions Inactive
@zinduolis zinduolis changed the title Fix forked SQLite connection handling to improve test accuracy (#3249) DRAFT - Fix forked SQLite connection handling to improve test accuracy (#3249) Aug 25, 2025
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 25, 2025 13:45 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 27, 2025 11:00 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 27, 2025 11:05 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 27, 2025 11:20 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 27, 2025 11:26 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 27, 2025 11:39 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 27, 2025 11:44 — with GitHub Actions Inactive
zinduolis and others added 2 commits August 28, 2025 18:44
Troubleshooting different behaviour of tests when running locally and on remote branch
@zinduolis zinduolis temporarily deployed to Integrate Pull Request August 28, 2025 08:47 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 1, 2025 11:11 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 1, 2025 11:22 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 1, 2025 11:31 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 1, 2025 11:58 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 1, 2025 12:34 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 2, 2025 23:40 — with GitHub Actions Inactive
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 3, 2025 00:04 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 3, 2025 00:18 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 3, 2025 00:31 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 3, 2025 00:43 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 5, 2025 23:58 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 6, 2025 00:19 — with GitHub Actions Failure
…for improved synchronization and conditional execution
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 6, 2025 00:36 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 6, 2025 00:43 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 6, 2025 00:52 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 6, 2025 00:56 — with GitHub Actions Failure
… hooked browser specs for improved synchronization
@zinduolis zinduolis had a problem deploying to Integrate Pull Request September 6, 2025 01:04 — with GitHub Actions Failure
…d browser specs for improved synchronization
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 6, 2025 01:11 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 6, 2025 01:23 — with GitHub Actions Inactive
@zinduolis zinduolis changed the title DRAFT - Fix forked SQLite connection handling to improve test accuracy (#3249) Fix forked SQLite connection handling to improve test accuracy (#3249) Sep 6, 2025
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 7, 2025 09:08 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request September 7, 2025 09:23 — with GitHub Actions Inactive
@zinduolis zinduolis merged commit c7665fb into master Sep 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning: Writable SQLite database connections inherited from forked process during test execution

1 participant