Conversation
…; refactor spec_helper.rb for improved fork handling
…ecs for improved SQL connection handling safety
Troubleshooting different behaviour of tests when running locally and on remote branch
… for improved initialization
…onsistency and teardown handling
…for improved synchronization and conditional execution
…sconnection in teardown
…sconnection in teardown
…sconnection in teardown
… hooked browser specs for improved synchronization
…d browser specs for improved synchronization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
Tests
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: Improve SQLite connection handling to fix test flakiness.
Q: Give a technical rundown of what you have changed (if applicable)
A: Add disconnect_all_active_record! calls before forking in multiple specs for improved SQL connection handling safety. Also fixed API Error.
Test Cases
Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: This fix is purely for tests to be more stable and from tests running by GitHub actions, from the checks running on this PR it will be evident when errors and warnings disappear.
Wiki Page
If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.