HealthKit should not remove metadata datapoints#474
Merged
theospears merged 2 commits intomasterfrom Sep 14, 2024
Merged
Conversation
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theospears and the rest of your teammates on |
theospears
changed the title
theospears
force-pushed
the
meta-data-points
branch
from
e12fbe3 to
c2c15de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HealthKit integration deletes all points which do not correspond to HealthKit entries. In the past this resulted in deleting points used for metadata tracking, e.g. derailments or restarts. This was confusing for support.
Resolve this by ignoring those points when syncing with HealthKit, so they are neither updated nor deleted.
Fixes #456