Merged
Conversation
theospears
pushed a commit
that referenced
this pull request
Oct 8, 2024
This is a follow-up to Commit e5ef0f / MR #484. It replaces uses of `asleep` with `asleepUnspecified` in the other targets (tests). ```diff - HKCategoryValueSleepAnalysis.asleep + HKCategoryValueSleepAnalysis.asleepUnspecified ```
Merged
krugerk
added a commit
to krugerk/BeeSwift
that referenced
this pull request
Nov 26, 2024
app was bumped to target ios17 with beeminder#484 and thus the code no longer need to check manually for iOS 14, 15, or 16
krugerk
added a commit
to krugerk/BeeSwift
that referenced
this pull request
Nov 26, 2024
app was bumped to target ios17 with beeminder#484 and thus the code no longer need to check manually for iOS 14, 15, or 16
theospears
pushed a commit
that referenced
this pull request
Nov 27, 2024
app was bumped to target ios17 with #484 and thus the code no longer need to check manually for iOS 14, 15, or 16
Contributor
|
related: #623 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases the minimum iOS version for BeeSwift to iOS17. Analytics data suggests that <2% of users are on iOS 16 or below. It also addresses the deprecation warnings associated with this new version.
Testing:
Confirmed it compiles