goalVC now also respects safe area

[krugerk]

goal view controller was not respecting the safe areas. This meant, for example, that the graph was partially hidden behind the Dynamic Island.

[theospears]

I've really appreciated the before/after screenshots you've included in some other PRs - could you add one here?

[krugerk]

I've really appreciated the before/after screenshots you've included in some other PRs - could you add one here?

sure.

This is what it looks like broken / currently:

The data area though on the goal vc accounted for the safe area:

thanks to

BeeSwift/BeeSwift/GoalViewController.swift

Lines 132 to 133 in a4b2744

	make.left.equalTo(self.goalImageScrollView).offset(sideMargin)
	make.right.equalTo(self.goalImageScrollView).offset(-sideMargin)

and

BeeSwift/BeeSwift/GoalViewController.swift

Lines 105 to 106 in a4b2744

	make.left.greaterThanOrEqualTo(self.scrollView.safeAreaLayoutGuide.snp.leftMargin)
	make.right.lessThanOrEqualTo(self.scrollView.safeAreaLayoutGuide.snp.rightMargin)

[theospears]

This seems reasonable, although I wonder if the app should even support landscape mode on phones

[krugerk]

This seems reasonable, although I wonder if the app should even support landscape mode on phones

Yeah that could be worth the discussion. This has been broken since iPhone X! (Some apps do purposely have content scroll inside the safe area and behind the Dynamic Island or into the status bar area.)
The app is (still) somewhat inconsistent about these sorts of things. Currently I am thinking we just iteratively clean it up, at least until the sweeping overhaul.

[krugerk]

mentioning #64, a table exclusive layout