badge count not reset upon logout#554
Merged
theospears merged 3 commits intoDec 19, 2024
Merged
Conversation
the same handler was being used for goals updated as for user signed out and the signed out case was not obtaining any goals and skipping the rest of the code and thus not setting a badge count fixes beeminder#553
krugerk
commented
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Badge count is not being set when a user logs out.
Validation
Ran the app in the simulator. Signed in with account that had beemergencies. Noted the badge count. Signed out. Noticed the badge count.
Issue
Fixes #553