list does not match website when sorting by pledge#579
Merged
theospears merged 2 commits intoDec 30, 2024
Conversation
and also cleaning up the code, using sorted(using:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When sorting by pledge, goals were sorted grouped by pledge amounts. The sort order within seemed undefined.
Also used the opportunity to clean the code somewhat using
sorted(using:)where multiple comparators may be provided.Validation
Ran app in simulator.
Compared before and after to list when sorting on the website.
Fixes #578