Skip to content

[DESK-5938] revamp WHM → WindowCoordinator, implement eclipsing coordinator & defaults#10

Merged
slice merged 20 commits into
mainfrom
skip/jj-xsmmpuyylruo
Feb 24, 2025
Merged

[DESK-5938] revamp WHM → WindowCoordinator, implement eclipsing coordinator & defaults#10
slice merged 20 commits into
mainfrom
skip/jj-xsmmpuyylruo

Conversation

@slice
Copy link
Copy Markdown
Contributor

@slice slice commented Feb 19, 2025

Apple has blocked us from using CGS*/SLS* private APIs, which we were using to punt the Messages app to an offscreen space whenever we needed to automate it. Since we can't do this anymore, we can opt to hide the app, but briefly unhide it behind the Beeper window whenever automation is needed (e.g. for reactions).

@slice slice requested a review from KishanBagaria February 19, 2025 03:11
@linear
Copy link
Copy Markdown

linear Bot commented Feb 19, 2025

DESK-5938 imessage: reactions don't work if the Messages window isn't on the main space

DESK-5237

just a note that baseline reactions (sonoma) is also broken on texts for many users — when the window isn't visible. we'd likely need to find a hacky solution here. perhaps show the window behind the beeper app window, react, and then hide. similar to RepositionWindowHidingManager

Copy link
Copy Markdown
Contributor Author

@slice slice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KishanBagaria i opted to nuke the old spaces code, but we'd actually want that for backwards compat right? i'm not aware of the exact version ranges that it works w/


static func registerDefaults() {
swiftServer.register(defaults: [
"BEEPWindowCoordination": true,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these keys be in an enum so it's easier to access? why the BEEP prefix?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the BEEP prefix?

oh, i can remove, but defaults keys are technically "global" in the sense that the suite name is just a search area. what i mean is that you can do yarn dev -BEEPWindowCoordination NO in beeper-desktop-new and it'd have the same effect as having compiled with NO_SPACES, basically. it searches the cli args before the suite

@KishanBagaria
Copy link
Copy Markdown
Member

@KishanBagaria i opted to nuke the old spaces code, but we'd actually want that for backwards compat right? i'm not aware of the exact version ranges that it works w/

yea it should work w the macOS 14

@slice slice added the WIP Work In Progress label Feb 19, 2025
@slice slice removed the WIP Work In Progress label Feb 20, 2025
@slice slice requested a review from KishanBagaria February 20, 2025 21:31
@slice slice changed the title [DESK-5938] briefly unhide Messages when automating, otherwise keep it hidden [DESK-5938] revamp WHM → WindowCoordinator, implement eclipsing coordinator Feb 20, 2025
@slice slice changed the title [DESK-5938] revamp WHM → WindowCoordinator, implement eclipsing coordinator [DESK-5938] revamp WHM → WindowCoordinator, implement eclipsing coordinator & defaults Feb 20, 2025
Comment thread src/SwiftServer/Sources/SwiftServer/Defaults.swift
Comment thread src/SwiftServer/Sources/SwiftServer/MessagesController.swift Outdated
@slice slice merged commit d2bba77 into main Feb 24, 2025
@KishanBagaria KishanBagaria mentioned this pull request May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants