Skip to content

Port PR88 to 1.3.1#99

Open
plenaerts wants to merge 1 commit into
beetbox:masterfrom
plenaerts:master
Open

Port PR88 to 1.3.1#99
plenaerts wants to merge 1 commit into
beetbox:masterfrom
plenaerts:master

Conversation

@plenaerts
Copy link
Copy Markdown

#88 by pranavkaruvally still stands as pointed out in the PR by sandrotosi in
#88 (comment)

Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1093700

Tested on a qemu s390x machine using the debian autopkgtest script fingerprint-calculation, which uses import acoustid; print(acoustid.fingerprint_file('$EXAMPLE_FILE')[1].decode()) as explained in PR88.

debian@debian:~/src/pyacoustid$ dpkg --print-architecture
s390x
debian@debian:~/src/pyacoustid$ git clean -fdx . && git reset --hard  
HEAD is now at fc66cab Refresh PR88.patch
debian@debian:~/src/pyacoustid$ bash ./debian/tests/fingerprint-calculation 
/usr/share/sounds/freedesktop/stereo/alarm-clock-elapsed.oga: OK
Not all generated fingerprints match the expected fingerprint for example file (/usr/share/sounds/freedesktop/stereo/alarm-clock-elapsed.oga):
  expected fingerprint  : AQAAHImSSEqSZFGiCLjxw9bxw8V9fMeJ-zhs4YeL48eJzzi8CSfM4DieAfcB5ZQ0QkgBjRLOCIegIeY5c5QA
  calculated via python3: AQAAHEmiJEqUJUnCCMd72Cf0KMSfoTzECa2SZbg5nIOn42EIPcoM-UIDxsp2XEyO9ygat9Cz5bgEDUwq4tICndAPMYwRjEBElBLOGCGQUN5YZAA
debian@debian:~/src/pyacoustid$ patch -p1 < debian/patches/PR88.patch 
patching file acoustid.py
debian@debian:~/src/pyacoustid$ bash ./debian/tests/fingerprint-calculation 
/usr/share/sounds/freedesktop/stereo/alarm-clock-elapsed.oga: OK
debian@debian:~/src/pyacoustid$ 

beetbox#88 by pranavkaruvally still
stands as pointed out in the PR by sandrotosi in
beetbox#88 (comment)

Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1093700
@github-actions
Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@pranavkaruvally
Copy link
Copy Markdown

Can someone please take a look at #88 or this PR and confirm whether this is the right way to approach?
If not how should the issue be addressed?

comment on the other thread: #88 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants