Skip to content

Comments

print bash commands as they are executed#96

Merged
freakboy3742 merged 1 commit intobeeware:mainfrom
rmartin16:show-bash-cmds
Feb 16, 2024
Merged

print bash commands as they are executed#96
freakboy3742 merged 1 commit intobeeware:mainfrom
rmartin16:show-bash-cmds

Conversation

@rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Feb 15, 2024

Changes

  • Use bash --noprofile --norc -x -e -o pipefail {0} as the shell for all run actions
  • I often feel lost in the workflow output; this helps keep track of where you are in the list of commands

Notes

  • My primary concern with this is we no longer inherit the list of bash options that GitHub uses by default.
  • That said, I think these options are quite stable and unlikely to meaningfully change over time.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review February 16, 2024 00:53
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say pulling apart the logs has caused me any particular difficulty myself - but then, you've spent a lot more time diagnosing weird CI workflow issues recently, so you might be seeing this more acutely than I am.

I'm not especially concerned about changes in Bash's arguments, though - if Bash changed an argument of any note, you'd be able to see the nerdrage from orbit :-) I'd be more concerned about missing some neat feature that Github rolls out as a default; but even then, it's an easy change to roll back (or modify) if that becomes an issue.

@freakboy3742 freakboy3742 merged commit 3181842 into beeware:main Feb 16, 2024
@rmartin16 rmartin16 deleted the show-bash-cmds branch February 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants