Align license terminology with SPDX License List#191
Align license terminology with SPDX License List#191freakboy3742 merged 3 commits intobeeware:mainfrom NMertsch:2270-improve-license-selection-wording
Conversation
freakboy3742
left a comment
There was a problem hiding this comment.
An idle thought - given that the SPDX names are actually identifiers, it might be better to use them as identifiers - that is, in this template, use the SPDX identifier as the thing that is selected, and then in Briefcase, use SPDX: full name as a key-value pair.
It's not essential that the name in the template be human readable, as it won't be exposed to the user under normal circumstances; and an SPDX identifier will be a lot less ambiguous than a matching a human-readable name in the template logic itself.
@freakboy3742 good idea, done in e10382d. |
|
@freakboy3742 Is any testing or documentation work expected for this PR? I assume that's all done in beeware/briefcase#2272. |
There's a sort of mutual testing that goes on. The template is tested - essentially we use the current "main" briefcase, pointed at this template, to verify that we can still generate a viable app; and then on the other side, Briefcase runs tests with the current "main" template. If you end up in a situation where the template needs an in-development version of Briefcase to pass, you can put: into the body of the template PR, and the test run will use the specified in-development version of Briefcase. When it comes time to merge, we'll merge the template, re-run CI on Briefcase, and then merge briefcase - usually in very rapid succession, to minimise the inconvenience. However, before it even gets to those tests, there's a pre-commit issue to resolve :-) |
freakboy3742
left a comment
There was a problem hiding this comment.
This looks good to me; I'll hold off merging until the matching Briefcase PR is ready to land.
|
beeware/briefcase#2272 has now been finalised, so we can land this. Thanks for the PR! |
Summary
Align license names with the SPDX License List.
Fixes beeware/briefcase#2270
Accompanies beeware/briefcase#2272
Please see beeware/briefcase#2272 for a longer description.
briefcase-repo: https://github.com/NMertsch/briefcase
briefcase-ref: 2270-improve-license-selection-wording
PR Checklist: