Skip to content

Include return codes in run failure messages.#2806

Merged
mhsmith merged 2 commits intobeeware:mainfrom
freakboy3742:run-status-code
Apr 24, 2026
Merged

Include return codes in run failure messages.#2806
mhsmith merged 2 commits intobeeware:mainfrom
freakboy3742:run-status-code

Conversation

@freakboy3742
Copy link
Copy Markdown
Member

While trying to diagnose intermittent Windows testing failures, I wasn't able to get any insight into why the run was failing, because the return code of the executed process wasn't being reported.

This PR adds the return code to run failure messages.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith April 24, 2026 04:49
@mhsmith mhsmith merged commit 292c0ab into beeware:main Apr 24, 2026
130 of 131 checks passed
@mhsmith
Copy link
Copy Markdown
Member

mhsmith commented Apr 24, 2026

"Return code 1" – so I guess that doesn't tell us much, but it might rule out some options.

@freakboy3742
Copy link
Copy Markdown
Member Author

freakboy3742 commented Apr 24, 2026

Yeah - two theories I had that are now ruled out:

  1. It's actually a failure of the log stream, not the app
  2. poll() is retuning None for some reason.

It also occurs to me that with the recent console attachment changes, it might be possible to move back to a "direct stdout" rather than a log stream.

@freakboy3742 freakboy3742 deleted the run-status-code branch April 26, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants