Include return codes in run failure messages.#2806
Merged
mhsmith merged 2 commits intobeeware:mainfrom Apr 24, 2026
Merged
Conversation
mhsmith
approved these changes
Apr 24, 2026
Member
|
"Return code 1" – so I guess that doesn't tell us much, but it might rule out some options. |
Member
Author
|
Yeah - two theories I had that are now ruled out:
It also occurs to me that with the recent console attachment changes, it might be possible to move back to a "direct stdout" rather than a log stream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to diagnose intermittent Windows testing failures, I wasn't able to get any insight into why the run was failing, because the return code of the executed process wasn't being reported.
This PR adds the return code to run failure messages.
PR Checklist: