Ensure listeners to Source objects are disconnected when data changes.
#4032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@corranwebster Thanks for the PR! As you know, the team is on leave for the holiday. We'll be checking in weekly, so we'll get to this next week. |
freakboy3742
approved these changes
Jan 5, 2026
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
One minor tweak to the changenote, and this looks good to go - thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
data/itemsetters of theDetailedList,Selection,TableandTreewidgets, this ensures that the implementation object is removed from the oldSource's listeners before the data is actually changed. This addresses the obvious issue raised in #4030 but does not fix the problem of disconnecting widgets when they are removed from the view.Ref #4030.
PR Checklist: