Added property to evaulate platform theme mode (iOS, web, Windows)#4408
Conversation
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for the PR.
The Winforms backend won't be accurate, because .NET 4 support for dark mode doesn't exist. However, AFAICT this will expose the user's preference for dark mode, which should be accurate, and could be manually reflected by the user, so it's better than the current 🤷 API response.
The only issue I'm seeing with this PR is a coverage gap - this is the source of the two Windows failures. The implication is that the key isn't set on the two test machines (which seems plausible - there's no reason for a dark mode preference to be set on a CI machine). We might need to mark that entire branch "no-cover" since we can't reliably test the outcome (if only because we don't know how the end-user's machine is configured.)
…eeware#4408) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Added property to evaulate platform theme mode
Fixes #2841
Credit to @Rjvs
PR Checklist:
Assisted-by: Cursor - for understanding the code structure