fix: assert uniqueness by origin (#3298)#4428
Conversation
8c6cbbb to
7af239c
Compare
1584703 to
9f1d405
Compare
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks like you've found a good workaround to the problem described by the original ticket.
The only feedback on the PR is that we try to avoid having platform-specific details in the testbed tests themselves, instead describing platform-specific details in terms of properties that individual probes can enable or disable as required.
However, in this case, I don't think there's a need for that. As noted inline, the key detail we need to assert is that the monitor origins are unique - there's no hard requirement that one of them is at (0,0).
So - if you can remove the "optional (0,0)" test, and remove the reference to Wayland in the test comment, this should be good to land!
09a2fc9 to
9cfd80a
Compare
Thanks for the feedback! I've removed the (0, 0) test. |
932aa06 to
9ecff5e
Compare
9ecff5e to
09cf370
Compare
09cf370 to
a2d8613
Compare
a02b9c6 to
a2d8613
Compare
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for that update - there was also a need to simplify the test comment; I've pushed an update to that effect (plus a simplification of the change note).
Thanks for the fix!
Fix
test_screensto handle duplicate monitor names on Linux Wayland by asserting uniqueness on origin instead of name, and skip thescreen[0] == (0, 0)check on Linux Wayland since it is not guaranteed.Fixes #3298
PR Checklist: