FPM/Nginx: allowing locally-accessed fpm status#102
Merged
bryanlatten merged 1 commit intomasterfrom Oct 7, 2016
Merged
Conversation
Contributor
|
👍 |
ko-be
reviewed
Oct 7, 2016
|
|
||
| # Allow locally-accessible (only) FPM status page | ||
| location ~ ^/__status$ { | ||
| access_log off; |
Collaborator
There was a problem hiding this comment.
we don't want to log this? are we 100% sure it's limited to local only @bryanlatten ? the access log would let us verify this.
Contributor
Author
There was a problem hiding this comment.
allow 127.0.0.1; restricts to local. I've manually confirmed that it doesn't expose beyond that. Just trying to keep the noise to a minimum - if this is accessed as part of a healthcheck, that's a duplicate access log
Contributor
Author
There was a problem hiding this comment.
@ko-be one better. nginx still DOES log on failure:
Collaborator
There was a problem hiding this comment.
As long as you manually verified it from outside, and if failures get logged, even better. @bryanlatten
Collaborator
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/__statusto not conflict with any application routes