ci: opt into Node 24 actions, label coverage step as >=90%#7
Merged
beingmartinbmc merged 1 commit intomainfrom May 2, 2026
Merged
ci: opt into Node 24 actions, label coverage step as >=90%#7beingmartinbmc merged 1 commit intomainfrom
beingmartinbmc merged 1 commit intomainfrom
Conversation
Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true at workflow level for both ci.yml and release.yml to silence the actions/checkout@v4 + actions/setup-node@v4 Node 20 deprecation warning. Rename the 'Test with coverage' step to 'Test with coverage gate (>=90%)' to make the threshold explicit. The threshold itself is unchanged — it is enforced via npm run test:coverage which is c8 --check-coverage --lines 90 --functions 90 --branches 90 --statements 90.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=trueat workflow level in bothci.ymlandrelease.ymlto silence the deprecation warning onactions/checkout@v4+actions/setup-node@v4.Test with coveragestep toTest with coverage gate (>=90%)so the threshold is explicit.Note
The 90% coverage threshold itself is unchanged — it is enforced via
npm run test:coveragewhich runsc8 --check-coverage --lines 90 --functions 90 --branches 90 --statements 90. This PR is workflow polish only.