Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #462 during exit we call
js_std_free_handlers()thenJS_FreeRuntime().js_std_free_handlers()frees theJSThreadStatememory. However, later inJS_FreeRuntime()we run GC, which runsjs_worker_finalizerand that accesses the port list from the already freedJSThreadState, so it results in a use-after-free error.To fix it try to run GC in
js_std_free_handlers()just before before cleaning and freeingJSThreadState.Fix #462