Skip to content

Fix worker port use-after-free #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+5 −0
Closed

Fix worker port use-after-free #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions quickjs-libc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4116,6 +4116,11 @@ void js_std_free_handlers(JSRuntime *rt)
JSThreadState *ts = JS_GetRuntimeOpaque(rt);
struct list_head *el, *el1;

/* Run GC before freeing the JSThreadState. The JSThreadState */
/* contains the worker port_list and JS_FreeRuntime migth reference */
/* it when it does worker defered finalization in JS_FreeRuntime */
JS_RunGC(rt);

list_for_each_safe(el, el1, &ts->os_rw_handlers) {
JSOSRWHandler *rh = list_entry(el, JSOSRWHandler, link);
free_rw_handler(rt, rh);
Expand Down