Quickfix to make it work with g++-15 on OSX #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
requested review from
camio,
dietmarkuehl and
neatudarius
as code owners
ClausKlein
commented
Jan 28, 2026
Comment on lines
+4
to
+7
| // FIXME: does not compile with g++-15 on OSX! CK | ||
| #if defined(__APPLE__) && defined(__GNUC__) | ||
| #undef BEMAN_HAS_IMPORT_STD | ||
| #endif |
Member
There was a problem hiding this comment.
OK. This is a limitation we can hopefully fix in the future.
5 tasks
dietmarkuehl
approved these changes
Jan 28, 2026
Comment on lines
+4
to
+7
| // FIXME: does not compile with g++-15 on OSX! CK | ||
| #if defined(__APPLE__) && defined(__GNUC__) | ||
| #undef BEMAN_HAS_IMPORT_STD | ||
| #endif |
Member
There was a problem hiding this comment.
OK. This is a limitation we can hopefully fix in the future.
Comment on lines
+58
to
+60
| # XXX export CMAKE_CXX_STDLIB_MODULES_JSON=${GCC_DIR}/lib/gcc/current/libstdc++.modules.json | ||
| export CXX=g++-15 | ||
| export CXXFLAGS=-stdlib=libstdc++ |
Member
There was a problem hiding this comment.
We'll need to find an arrangement for these: I don't have g++ on my OSX systems because they are ARM based. I believe these two lines set the compiler and flags in a way which I also can't override, e.g., using environment variables.
Member
|
There seem to be some CI failures for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang++ and libstd++!GenerateExportHeader.cmakeIn file included from /usr/share/libc++/v1/std.cppm:229:
/usr/share/libc++/v1/std/cstdio.inc:24:14: error: using declaration referring to 'fprintf' with internal linkage cannot be exported