Skip to content

added tests for completions being called and fixed an issue with let#265

Merged
dietmarkuehl merged 3 commits intomainfrom
test-completion-signatures
Apr 26, 2026
Merged

added tests for completions being called and fixed an issue with let#265
dietmarkuehl merged 3 commits intomainfrom
test-completion-signatures

Conversation

@dietmarkuehl
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 25, 2026 20:43
@dietmarkuehl dietmarkuehl requested a review from camio as a code owner April 25, 2026 20:43
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 25, 2026

Coverage Status

coverage: 95.542%. remained the same — test-completion-signatures into main

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a small testing sender adapter to verify that senders’ advertised completion signatures correspond to completion calls that can actually be made, and updates let’s completion signature computation to include set_error(exception_ptr) when the let function may throw.

Changes:

  • Add test::completion_test sender wrapper that converts any completion (set_value/set_error/set_stopped) into a set_value() completion for use with sync_wait.
  • Add new completion-signature smoke tests for just and let_value pipelines.
  • Fix let completion signatures to include set_error_t(std::exception_ptr) when invoking the provided function is not noexcept.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
tests/beman/execution/include/test/completion_test.hpp New test helper sender/receiver used to validate that advertised completions are callable.
tests/beman/execution/exec-let.test.cpp Adds a let_value completion-signature test using the new helper.
tests/beman/execution/exec-just.test.cpp Adds just/just_error/just_stopped completion-signature tests using the new helper.
include/beman/execution/detail/let.hpp Extends let completion-signature computation to account for potentially-throwing Fun invocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/beman/execution/include/test/completion_test.hpp Outdated
Comment thread tests/beman/execution/include/test/completion_test.hpp
Comment thread tests/beman/execution/include/test/completion_test.hpp Outdated
Comment thread tests/beman/execution/exec-let.test.cpp
@dietmarkuehl dietmarkuehl merged commit c4e8d61 into main Apr 26, 2026
38 checks passed
@dietmarkuehl dietmarkuehl deleted the test-completion-signatures branch April 26, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants