Skip to content

Disable apple clang presets#277

Open
ClausKlein wants to merge 3 commits into
bemanproject:mainfrom
ClausKlein:feature/disable-apple-clang-presets
Open

Disable apple clang presets#277
ClausKlein wants to merge 3 commits into
bemanproject:mainfrom
ClausKlein:feature/disable-apple-clang-presets

Conversation

@ClausKlein
Copy link
Copy Markdown
Collaborator

@ClausKlein ClausKlein commented May 26, 2026

Motivation: as the apple-clang toolchain is not supported, I hide this presets.

@ClausKlein ClausKlein self-assigned this May 26, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 26, 2026

Coverage Status

coverage: 95.409%. remained the same — ClausKlein:feature/disable-apple-clang-presets into bemanproject:main

Comment thread .pre-commit-config.yaml
Comment on lines +63 to +66
# - repo : https://github.com/bemanproject/beman-tidy
# rev: v0.3.1
# hooks:
# - id: beman-tidy
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dietmarkuehl This fails locally! No idea why?

@ClausKlein
Copy link
Copy Markdown
Collaborator Author

bash-5.3$ pre-commit run --all
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check json...............................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
codespell................................................................Passed
clang-format.............................................................Passed
CMake linting............................................................Passed
isort....................................................................Passed
black....................................................................Passed
beman-tidy...............................................................Failed
- hook id: beman-tidy
- exit code: 2

beman-tidy pipeline started ...

Running check [Requirement][license.approved] ... 
[info][license.approved]: Valid Apache License - Version 2.0 with LLVM Exceptions found in LICENSE file.
	check [Requirement][license.approved] ... passed

Running check [Recommendation][license.apache_llvm] ... 
	check [Recommendation][license.apache_llvm] ... passed

Running check [Requirement][license.criteria] ... 
[info][license.criteria]: beman-tidy cannot actually check license.criteria. Please ignore this message if license.approved has passed. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#licensecriteria for more information.
[skipped][license.criteria]: beman-tidy cannot actually check license.criteria. Please ignore this message if license.approved has passed. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#licensecriteria for more information.
Running check [Requirement][license.criteria] ... skipped

Running check [Recommendation][library.name] ... 
[info][library.name]: beman-tidy cannot actually check library.name. Please ignore this message if cmake.library_name and repository.name have passed. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#libraryname for more information.
[skipped][library.name]: beman-tidy cannot actually check library.name. Please ignore this message if cmake.library_name and repository.name have passed. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#libraryname for more information.
Running check [Recommendation][library.name] ... skipped

Running check [Requirement][repository.name] ... 
	check [Requirement][repository.name] ... passed

Running check [Requirement][repository.default_branch] ... 
	check [Requirement][repository.default_branch] ... passed

Running check [Requirement][repository.codeowners] ... 
	check [Requirement][repository.codeowners] ... passed

Running check [Requirement][repository.code_review_rules] ... 
[info][repository.code_review_rules]: beman-tidy cannot actually check repository.code_review_rules. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#repositorycode_review_rules.
[skipped][repository.code_review_rules]: beman-tidy cannot actually check repository.code_review_rules. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#repositorycode_review_rules.
Running check [Requirement][repository.code_review_rules] ... skipped

Running check [Recommendation][repository.disallow_git_submodules] ... 
	check [Recommendation][repository.disallow_git_submodules] ... passed

Running check [Requirement][release.github] ... 
[info][release.github]: beman-tidy cannot actually check release.github. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#releasegithub.
[skipped][release.github]: beman-tidy cannot actually check release.github. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#releasegithub.
Running check [Requirement][release.github] ... skipped

Running check [Recommendation][release.notes] ... 
[info][release.notes]: beman-tidy cannot actually check release.notes. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#releasenotes.
[skipped][release.notes]: beman-tidy cannot actually check release.notes. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#releasenotes.
Running check [Recommendation][release.notes] ... skipped

Running check [Recommendation][release.godbolt_trunk_version] ... 
[warning][release.godbolt_trunk_version]: The file 'README.md' does not contain a Compiler Explorer badge - trunk version assumed to be missing.
	check [Recommendation][release.godbolt_trunk_version] ... failed

Running check [Requirement][toplevel.cmake] ... 
	check [Requirement][toplevel.cmake] ... passed

Running check [Requirement][toplevel.license] ... 
	check [Requirement][toplevel.license] ... passed

Running check [Requirement][toplevel.readme] ... 
	check [Requirement][toplevel.readme] ... passed

Running check [Recommendation][readme.title] ... 
[warning][readme.title]: The first line of the file 'README.md' is invalid. It should start with '# beman.execution26: <short_description>'.
	check [Recommendation][readme.title] ... failed

Running check [Requirement][readme.badges] ... 
	check [Requirement][readme.badges] ... passed

Running check [Recommendation][readme.purpose] ... 
[info][readme.purpose]: beman-tidy cannot actually check readme.purpose. Please add a one line summary describing the library's purpose.See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#readmepurpose.
[skipped][readme.purpose]: beman-tidy cannot actually check readme.purpose. Please add a one line summary describing the library's purpose.See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#readmepurpose.
Running check [Recommendation][readme.purpose] ... skipped

Running check [Recommendation][readme.implements] ... 
[warning][readme.implements]: Invalid/missing/duplicate 'Implements:' line in 'README.md'. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#readmeimplements for more information.
	check [Recommendation][readme.implements] ... failed

Running check [Requirement][readme.library_status] ... 
	check [Requirement][readme.library_status] ... passed

Running check [Requirement][readme.license] ... 
	check [Requirement][readme.license] ... passed

Running check [Requirement][directory.sources] ... 
[error][directory.sources]: Please use the required source files location: src/beman/execution26. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#directorysources for more information.
	check [Requirement][directory.sources] ... failed

Running check [Requirement][directory.tests] ... 
[error][directory.tests]: The directory 'tests/beman/execution26' does not exist.
	check [Requirement][directory.tests] ... failed

Running check [Requirement][directory.examples] ... 
	check [Requirement][directory.examples] ... passed

Running check [Requirement][directory.docs] ... 
	check [Requirement][directory.docs] ... passed

Running check [Requirement][directory.papers] ... 
	check [Requirement][directory.papers] ... passed

Running check [Recommendation][file.copyright] ... 
	check [Recommendation][file.copyright] ... passed

Running check [Recommendation][cpp.namespace] ... 
	check [Recommendation][cpp.namespace] ... passed


beman-tidy pipeline finished.

Summary    Requirement:  13 checks passed, 2 checks failed, 3 checks skipped,  8 checks not implemented.
Summary Recommendation:  4 checks passed, 3 checks failed, 3 checks skipped,  11 checks not implemented.

Coverage    Requirement:  57.14% (16/28 checks passed).
Coverage Recommendation:  70.00% (7/10 checks passed).
Coverage          TOTAL:  60.53% (23/38 checks passed).

bash-5.3$ git push --set-upstream origin feature/disable-apple-clang-presets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants