Conversation
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
As evidenced by testing this with utf_view, which depends on transform_view, this test does not work properly if a library has dependencies that need to be installed. This commit removes it; in the future, a new implementation of this test using vcpkg will be developed.
ednolan
force-pushed
the
enolan_rminstalltest1
branch
from
e900df8 to
2c0b4ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As evidenced by testing this with utf_view, which depends on transform_view, this test does not work properly if a library has dependencies that need to be installed. This commit removes it; in the future, a new implementation of this test using vcpkg will be developed.