Use cookiecutter.cpp_build_version in README#313
Conversation
Previously, this was hardcoded to 20.
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
|
|
||
| ```bash | ||
| cmake -B build -S . -DCMAKE_CXX_STANDARD=20 -DBEMAN_EXEMPLAR_BUILD_TESTS=OFF | ||
| cmake -B build -S . -DCMAKE_CXX_STANDARD=17 -DBEMAN_EXEMPLAR_BUILD_TESTS=OFF |
There was a problem hiding this comment.
I realize you already merged, but this strikes me as strange -- wouldn't we wnat to put the minimum value there? And I don't like that we went to 17 -- every Beman library requires 20+
There was a problem hiding this comment.
17 is the minimum version for this case— beman.exemplar supports c++17 and cookiecutter libraries stamped out from it will also build with c++17 in CI by default. Maybe I should rename this cookiecutter parameter from cpp_build_version to cpp_minimum_build_version. Before this commit, that parameter was actually entirely unused; the only thing it's used for now is filling in these README examples.
There was a problem hiding this comment.
4448085 renames cpp_build_version to minimum_cpp_build_version.
2 participants
Previously, this was hardcoded to 20.