Conversation
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
This is mainly for the benefit of the README and the cookiecutter template, whose untemplated uses of identity.hpp had been leaking into other libraries. Since the catchall header is called exemplar.hpp, we can template it, so that when we stamp out new_library the README will show new_library.hpp instead of identity.hpp. Providing a catchall header can also be good practice in general so that users don't need to individually include every header in the project.
ednolan
force-pushed
the
enolan_catchallheader1
branch
from
30583d7 to
407cfb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly for the benefit of the README and the cookiecutter template, whose untemplated uses of identity.hpp had been leaking into other libraries. Since the catchall header is called exemplar.hpp, we can template it, so that when we stamp out new_library the README will show new_library.hpp instead of identity.hpp. Providing a catchall header can also be good practice in general so that users don't need to individually include every header in the project.