Remove redundant GTest::gtest from test link libraries#341
Merged
ednolan merged 1 commit intobemanproject:mainfrom Apr 2, 2026
Merged
Remove redundant GTest::gtest from test link libraries#341ednolan merged 1 commit intobemanproject:mainfrom
ednolan merged 1 commit intobemanproject:mainfrom
Conversation
GTest::gtest_main is an alternative to GTest::gtest, not an addition. Linking both causes duplicate library warnings and linker errors on some platforms. Fixes bemanproject#292 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
camio
requested review from
bretbrownjr,
dietmarkuehl,
ednolan,
neatudarius,
steve-downey and
wusatosi
as code owners
ednolan
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GTest::gtestfromtarget_link_libraries, keeping onlyGTest::gtest_maintests/andcookiecutter/CMakeLists.txt filesGTest::gtest_mainis an alternative toGTest::gtest, not an addition. Linking both causes duplicate library warnings and linker errors on some platforms.Fixes #292. Carries forward the agreed-upon portion of #294 (the
BUILD_GMOCKchanges from that PR were intentionally excluded per review feedback).Test plan
cmake --workflow --preset appleclang-debugpasses (configure, build, all 4 tests)🤖 Generated with Claude Code