Closed
Conversation
ClausKlein
requested review from
JeffGarland,
ednolan,
neatudarius,
rishyak and
wusatosi
as code owners
Member
|
@ednolan , I believe the intention for clang-tidy config and pre-commit hook was to not ship it with infra but with exemplar? |
JeffGarland
reviewed
Jan 18, 2026
| rev: 0.22.3 | ||
| rev: 0.23.2 | ||
| hooks: | ||
| - id: gersemi |
Member
There was a problem hiding this comment.
I'm just going to note that from a policy point of view we've discussed removing this since gersemi isn't telling really helpful
Author
There was a problem hiding this comment.
I like it, it is better than formatting manually!
JeffGarland
reviewed
Jan 18, 2026
| @@ -0,0 +1,10 @@ | |||
| --- | |||
| BasedOnStyle: LLVM | |||
Member
There was a problem hiding this comment.
how does this compare with what optional is doing? We probably need to have an independent discussion of these. I'm also used to this file going in the top level of a repo -- so maybe this part needs to be examplar?
Author
There was a problem hiding this comment.
it is only needed to format json files with clang-tidy
Add formatting hooks for json, python and apply all
Author
|
timeout, close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add formatting hooks for json, python
and apply all