Skip to content

Conversation

@wermos
Copy link
Contributor

@wermos wermos commented Jun 14, 2025

This PR just fixes spelling mistakes.

While looking through the README, I noticed that the minimum C++ version is C++20, but the Install beman.iterator_interface (verbose logs - gcc-release) example installs an iterator_interface built with C++17. That should probably be fixed.

@wermos wermos requested review from a team, JeffGarland and RaduNichita June 14, 2025 15:05
Copy link
Member

@JeffGarland JeffGarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ship it.

@neatudarius neatudarius merged commit e854abf into bemanproject:main Jun 14, 2025
7 checks passed
@wermos wermos deleted the readme branch July 6, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants