Some modifications for Beman standard conformance#8
Merged
steve-downey merged 1 commit intobemanproject:mainfrom Oct 18, 2024
Merged
Some modifications for Beman standard conformance#8steve-downey merged 1 commit intobemanproject:mainfrom
steve-downey merged 1 commit intobemanproject:mainfrom
Conversation
- Use FetchContent to pull in GoogleTest instead of a submodule. - Change external interface to match library name. - Rename directories. These changes were needed to incorporate this into another project that uses both GoogleTest and beman.iterator_interface26.
Merged
steve-downey
approved these changes
Oct 18, 2024
Member
steve-downey
left a comment
steve-downey
left a comment
There was a problem hiding this comment.
Looks good to me.
Thanks for taking the time to clean this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were needed to incorporate this into another project that
uses both GoogleTest and beman.iterator_interface26.