Skip to content

change the tag names to implement P4154#58

Merged
dietmarkuehl merged 1 commit intomainfrom
use-tag-types-P4154
May 4, 2026
Merged

change the tag names to implement P4154#58
dietmarkuehl merged 1 commit intomainfrom
use-tag-types-P4154

Conversation

@dietmarkuehl
Copy link
Copy Markdown
Member

No description provided.

@dietmarkuehl dietmarkuehl requested a review from camio as a code owner May 4, 2026 22:51
Copilot AI review requested due to automatic review settings May 4, 2026 22:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project to use the P4154 “tag” naming for execution concepts by renaming the *_concept tag types used throughout net internals and examples, and adjusts the pinned bemanproject/task dependency commit accordingly.

Changes:

  • Replace receiver_t/sender_t/operation_state_t/scheduler_t concept tag names with receiver_tag/sender_tag/operation_state_tag/scheduler_tag.
  • Update beman::net::detail::ex re-exports to forward the new *_tag names from beman::execution.
  • Update examples to match the new tag names and change the task FetchContent commit.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
include/beman/net/detail/sender.hpp Switch internal sender/receiver/operation_state concept tag aliases to *_tag.
include/beman/net/detail/repeat_effect_until.hpp Update adaptor state/sender concept tag aliases to *_tag.
include/beman/net/detail/io_context.hpp Update run_one_state and run_one_sender concept tag aliases to *_tag.
include/beman/net/detail/io_context_scheduler.hpp Update scheduler/sender/state concept tag aliases to *_tag.
include/beman/net/detail/into_expected.hpp Update adaptor receiver/state/sender concept tag aliases to *_tag.
include/beman/net/detail/execution.hpp Re-export beman::execution::*_tag names via beman::net::detail::ex.
examples/sync_run.hpp Update example receiver tag alias to receiver_tag.
examples/server.cpp Update example receiver tag alias to receiver_tag.
examples/print_completions.hpp Update example sender/state concept tag aliases to *_tag.
examples/postgres.cpp Update example sender/state concept tag aliases to *_tag.
examples/demo_task.hpp Update example receiver/state/sender concept tag aliases to *_tag.
examples/demo_stream.hpp Update example sender/state concept tag aliases to *_tag.
examples/demo_scope.hpp Update example receiver concept tag alias to receiver_tag.
examples/demo_algorithm.hpp Update example sender/receiver/state concept tag aliases to *_tag.
CMakeLists.txt Update the pinned bemanproject/task commit hash used via FetchContent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CMakeLists.txt
Comment on lines 30 to 36
FetchContent_Declare(
task
# SOURCE_DIR ${CMAKE_SOURCE_DIR}/../task
GIT_REPOSITORY https://github.com/bemanproject/task
GIT_TAG 6ff5b89
GIT_TAG 1679185
FIND_PACKAGE_ARGS 0.2.0 EXACT NAMES beman.task COMPONENTS task_headers
)
@dietmarkuehl dietmarkuehl merged commit 8350abf into main May 4, 2026
41 checks passed
@dietmarkuehl dietmarkuehl deleted the use-tag-types-P4154 branch May 4, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants