Fix noexcept#91
Merged
dietmarkuehl merged 5 commits intomainfrom Apr 27, 2026
Merged
Conversation
dietmarkuehl
requested review from
bretbrownjr,
steve-downey and
wusatosi
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address a noexcept-related issue in the task sender implementation, and updates the pinned bemanproject/execution dependency revision that this library builds against.
Changes:
- Updates
task::connectto take a forwarding reference and adds anoexceptspecifier. - Bumps the fetched
bemanproject/executioncommit inCMakeLists.txt.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/beman/task/detail/task.hpp | Adjusts task::connect signature and exception specification. |
| CMakeLists.txt | Updates the pinned bemanproject/execution GIT_TAG. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
coverage: 94.059%. remained the same — fix-noexcept into main |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.