Skip to content

Restore beman-tidy pre-commit hook unintentionally removed by e7f108cab6e5af830aeb30097878f3d555e3de1d#39

Merged
ednolan merged 1 commit intomainfrom
enolan_restorebemantidy1
Apr 27, 2026
Merged

Restore beman-tidy pre-commit hook unintentionally removed by e7f108cab6e5af830aeb30097878f3d555e3de1d#39
ednolan merged 1 commit intomainfrom
enolan_restorebemantidy1

Conversation

@ednolan
Copy link
Copy Markdown
Member

@ednolan ednolan commented Apr 27, 2026

This was an unintentional change caused by my automated update process misinterpreting the commit
bemanproject/exemplar@068a39c as meaning that beman-tidy should be removed from the pre-commit config. I caught this problem elsewhere but missed it here.

This was an unintentional change caused by my automated update process
misinterpreting the commit
bemanproject/exemplar@068a39c
as meaning that beman-tidy should be removed from the pre-commit
config. I caught this problem elsewhere but missed it here.
@ednolan ednolan requested a review from TedLyngmo as a code owner April 27, 2026 13:14
@ednolan ednolan merged commit 7e85bcc into main Apr 27, 2026
75 checks passed
@ednolan ednolan deleted the enolan_restorebemantidy1 branch April 27, 2026 13:15
ednolan referenced this pull request Apr 27, 2026
Bump infra-workflows from 1.5.0 to 1.5.1 in all GitHub Actions workflow files.
Bump infra-workflows version from 1.5.1 to 1.5.2 in all GitHub Actions workflow files (fixes deprecated Node.js v20 actions).
Add build telemetry support: include BuildTelemetryConfig.cmake and call configure_build_telemetry() in CMakeLists.txt; update infra to commit dfdb103 (adds BuildTelemetry.cmake, BuildTelemetryConfig.cmake, telemetry.sh; updates beman-install-library.cmake, Config.cmake.in, use-fetch-content.cmake, .pre-commit-config.yaml, README.md).
Bump infra-workflows version from 1.5.2 to 1.5.3 in all GitHub Actions workflow files.
Remove explicit args from beman-tidy pre-commit hook to use defaults instead of ["." "--verbose" "--require-all"].
Split Clang 18/17 CI matrix entry into separate entries, restoring Clang 18 + libstdc++ + c++23 test (exemplar 26982cd907aa137d046ed536dd1b2db4fbc16f03)
b1e7015b1bd62ce5b20009cec7ee98ba5c783818: Remove beman-tidy pre-commit hook from .pre-commit-config.yaml
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage is 100.0%enolan_restorebemantidy1 into main. No base build found for main.

Copy link
Copy Markdown
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants