Refactor use of std::nontype to use std::constant_wrapper instead per P3948#196
Merged
Refactor use of std::nontype to use std::constant_wrapper instead per P3948#196
Conversation
… P3948 std::nontype no longer exists in the C++ standard draft, as it was removed by P3948 (and, previously, renamed by P3774), so when GCC implemented __cpp_lib_function_ref, the std::nontype polyfill tried to switch to the standard library's nonexistent std::nontype implementation, causing the build to fail. This commit replaces the std::nontype polyfill with a std::constant_wrapper polyfill and updates the paper to reflect this change.
|
coverage: 99.738%. remained the same — enolan_p3948_1 into main |
jwakely
reviewed
Apr 26, 2026
| @@ -0,0 +1,37 @@ | |||
| // SPDX-License-Identifier: BSL-1.0 | |||
|
|
|||
| // Copyright Eddie Nolan and Jonathan Wakely 2023 - 2025. | |||
Collaborator
There was a problem hiding this comment.
This file is new in 2026, and it's all your work, isn't it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::nontype no longer exists in the C++ standard draft, as it was removed by P3948 (and, previously, renamed by P3774), so when GCC implemented __cpp_lib_function_ref, the std::nontype polyfill tried to switch to the standard library's nonexistent std::nontype implementation, causing the build to fail.
This commit replaces the std::nontype polyfill with a std::constant_wrapper polyfill and updates the paper to reflect this change.