Replace iterator's back-pointer with previous three-iterator design#206
Merged
Conversation
|
coverage: 99.744% (+0.006%) from 99.738% — enolan_restoreborrowedness1 into main |
After considering the fact that views::adjacent<N> means that the library has precedent for views whose iterators contain multiple iterators from the base view, and the fact that, since R10 broke .base() consistency to implement the double-transcode optimization, we no longer need the innermost-iterator machinery, I realized that it was possible to restore the three-iterator design from P2728R7 and before, and with it, the borrowedness of the view.
ednolan
force-pushed
the
enolan_restoreborrowedness1
branch
from
9113eb2 to
c4cadcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After considering the fact that views::adjacent means that the library has precedent for views whose iterators contain multiple iterators from the base view, and the fact that, since R10 broke .base() consistency to implement the double-transcode optimization, we no longer need the innermost-iterator machinery, I realized that it was possible to restore the three-iterator design from P2728R7 and before, and with it, the borrowedness of the view.