Added devcontainer support #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguludag
force-pushed
the
9-provide-github-devcontainer-support
branch
from
b5520fa to
67bd53b
Compare
RaduNichita
reviewed
Apr 12, 2025
Collaborator
RaduNichita
left a comment
RaduNichita
left a comment
There was a problem hiding this comment.
Hey @mguludag, many thanks for the contribution! It looks pretty ok to me, could you please a small section in the README.md about how to use .devcontainer, please?
.devcontainer/devcontainer.json
Outdated
| }, | ||
| "github-cli": "latest" | ||
| } | ||
| } No newline at end of file |
.github/workflows/deploy.yml
Outdated
| steps: | ||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v4 No newline at end of file |
Collaborator
There was a problem hiding this comment.
Suggested change
| uses: actions/deploy-pages@v4 | |
| uses: actions/deploy-pages@v4 | |
.github/workflows/deploy.yml
Outdated
| name: Deploy to GitHub Pages | ||
| needs: build | ||
|
|
||
| # Grant GITHUB_TOKEN the permissions required to make a Pages deployment |
Collaborator
There was a problem hiding this comment.
Can you put a TODO here, please?
mguludag
force-pushed
the
9-provide-github-devcontainer-support
branch
from
67bd53b to
072c768
Compare
Member
Author
Instructions for devcontainer is added into README.md |
mguludag
force-pushed
the
9-provide-github-devcontainer-support
branch
from
072c768 to
160481b
Compare
✅ Deploy Preview for bemanproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RaduNichita
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9
Created the devcontainer file from https://github.com/facebook/docusaurus/blob/main/.devcontainer/devcontainer.json
Created the deploy workflow from https://docusaurus.io/docs/deployment#triggering-deployment-with-github-actions